Add and use readLE/writeLE helpers#8470
Merged
kripken merged 1 commit intoWebAssembly:mainfrom Mar 20, 2026
Merged
Conversation
sertonix
force-pushed
the
be
branch
2 times, most recently
from
dd5afc4 to
caaf83e
Compare
Member
|
Have you confirmed these fix the big-endian errors? |
Contributor
Author
|
There are still test failures but I think more tests pass with this change. I haven't done a direct comparison of tests failing with and without this change yet. Some of my test logs can be found here: https://gitlab.alpinelinux.org/sertonix/aports/-/merge_requests/179 |
kripken
reviewed
Mar 20, 2026
Contributor
Author
I did that now and the diff look promising: -[ 180 failures! ]
+[ 29 failures! ] |
kripken
reviewed
Mar 20, 2026
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Looks good aside from a style nit
According to godbolt.org these functions optimize to a simple *(T *)ptr in many cases while ensuring that memory alignment requirements and endianess does not effect the behavior. The unroll pragma is needed for GCC to properly optimize the code. The approach of using bit shifts is also used in multiple other parts of binaryen (eg. WasmBinaryReader::getInt16) but usage of the helper function doesn't seem to be that easy there. Ref WebAssembly#2983
kripken
approved these changes
Mar 20, 2026
Member
|
Have you fuzzed this? I'm running it now locally. |
Contributor
Author
I don't think so. I ran whatever |
Member
|
I don't see any fuzz issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to godbolt.org these functions optimize to a simple
*(T *)ptrin many cases while ensuring that memory alignment requirements and endianess does not effect the behavior.The unroll pragma is needed for GCC to properly optimize the code.
The approach of using bit shifts is also used in multiple other parts of binaryen (eg.
WasmBinaryReader::getInt16) but usage of the helper function doesn't seem to be that easy there.Ref #2983